Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] document_page: improve readability when viewing content f… #528

Closed
wants to merge 1 commit into from

Conversation

lbarry-apsl
Copy link
Member

Improve readability when viewing content fields

cc https://helpdesk.apsl.net/ HT01756

@miquelalzanillas @peluko00 @mpascuall @ppyczko @javierobcn @BernatObrador please review

Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@javierobcn javierobcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, working

@lbarry-apsl
Copy link
Member Author

Hi @victoralmau ,

Can you please check this for me to merge?

Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the reason for adding that (reviewing v16 I see it correct as it is currently), can you indicate for example a screenshot of the before and after that will help everyone to understand it better?

Thanks.

@lbarry-apsl
Copy link
Member Author

I don't understand the reason for adding that (reviewing v16 I see it correct as it is currently), can you indicate for example a screenshot of the before and after that will help everyone to understand it better?

Thanks.

Hi @victoralmau ,

This is the before and after:

Before:
Captura desde 2025-03-12 09-14-37

After:
Captura desde 2025-03-12 09-14-54

It's an improvement for reading. It eliminates the need for line breaks, so the line doesn't end up so long.

I think it's more pleasant for the reader.

@victoralmau
Copy link
Member

Ok, but what is the problem with the current display that tries to take advantage of almost 100% of the available width? I'm sorry but I don't understand this fix.

@lbarry-apsl
Copy link
Member Author

Ok, but what is the problem with the current display that tries to take advantage of almost 100% of the available width? I'm sorry but I don't understand this fix.

Sorry for the confusion @victoralmau

It's not a fix, it's an improvement.

@victoralmau
Copy link
Member

improvement

Sorry, I didn't mean if it was fix or improvement, I just don't see that it is necessary; I mean, now you use “as much as possible” the available space, and now you want to use only 75%, I really don't understand that it is necessary (although it's just my opinion looking at the screenshots).

@lbarry-apsl
Copy link
Member Author

Sorry @victoralmau ,

Now, reviewing it with my colleague, we see that you're absolutely right.

I'm going to close this PR.

Sorry for the inconvenience. Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants